Chris Maynard
changed
bug 8532
What |
Removed |
Added |
Attachment #10481 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 8532
from Chris Maynard
Comment on attachment 10481 [details]
patch
>From section 6 of 3GPP TS 23.032:
The longitude, expressed in the range -180°, +180°, is coded as a number
between -2^23 and 2^23-1, coded in 2's complement binary on 24 bits.
So the result of tvb_get_ntoh24(tvb,offset)&0xffffff should be assigned to a
signed integer, not an unsigned integer.
And also:
1) The sign of the latitude isn't being displayed.
2) The display filter for hf_gsm_a_geo_loc_deg_of_lat is wrong.
3) The display filter for hf_gsm_a_geo_loc_deg_of_long is wrong.
4) The FT_UINT24 for hf_gsm_a_geo_loc_deg_of_long is wrong.
You are receiving this mail because:
- You are watching all bug changes.