[bugzilla-daemon@xxxxxxxxxxxxx]

Comment # 4 on bug 8507 from Jaap Keuter

Quick review:

ip_addr = tvb_get_ipv4(tvb, offset + 12);
proto_tree_add_ipv4(uhd_tree, hf_uhd_ip_addr, tvb, offset+12, 4, ip_addr);

can become

proto_tree_add_item(uhd_tree, hf_uhd_ip_addr, tvb, offset+12, 4,
ENC_BIG_ENDIAN);

Also, why use 'offset', since it never changes value?

---

      You are receiving this mail because:

• You are watching all bug changes.