Wireshark-bugs: [Wireshark-bugs] [Bug 8501] HomeplugAV dissector: Decoding HPAV-1.1 Tone Map Tx/

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 21 Mar 2013 18:50:17 +0000

Comment # 5 on bug 8501 from 
Hello Florian

> I am not too happy with this patch as it breaks the semantics of the
> HomePlug AV 1.0 ToneMap Request/Confirm frames by splitting the TX/RX paths
> unconditionnaly. Even though it requires some code duplication, I prefer
> that we keep the HPAV 1.0 and HPAV 1.1 ToneMap Confirm paths well distinct.

Quick question to understand your comment correctly before changing the patch:
Should I create also a Tx/RX dissector pair for the ToneMap Request? 
And/or create separate dissector functions for ToneMap Tx-1.0, Tx-1.1, Rx-1.0,
Rx-1.1?

For debugging I have added an attachment with a capture containing HPAV-1.0 Tx
and Rx Req/Confirm messages.

Regards,
Guus

You are receiving this mail because:
  • You are watching all bug changes.