Comment # 13
on bug 8070
from Shoichi Sakane
(In reply to comment #12)
> The tools/checkhf.pl script reports one issue:
> Unused entry: epan/dissectors/packet-coap.c, hf_coap_opt_if_none_match
>
> Otherwise it looks good.
>
> (if the extra hf entry is unneeded you don't have to submit a new patch - I
> can apply the old one and remove the extra lines)
If-Mone-Match option doesn't carry any option payload itself.
So, please just remove the unused code. Thanks.
The problem would be that a user of tshark -T coap.opt.if_none_matchcould not
know whether the option If-None-Match option is present or not.A wireshark user
can know it when he check the Packet Details window because packet-coap.c shows
information about each option header.
I think it's rare case. I will fix it in the future if somebody needs to use
tshark.
Shoichi
You are receiving this mail because:
- You are watching all bug changes.