Evan Huus
changed
bug 8371
| What |
Removed |
Added |
| Attachment #10081 Flags |
|
review_for_checkin-
|
Comment # 3
on bug 8371
from Evan Huus
Comment on attachment 10081 [details]
Patch to open reference packet in new window
So, I've taken a quick look. In general it looks nice, but the indentation is a
bit messed up. The existing code uses tabs, while your patch uses 4-spaces.
Also, on my latest GCC it produces one compiler error:
packet_win.c: In function ‘new_packet_window’:
packet_win.c:893:12: error: ‘framenum’ may be used uninitialized in this
function [-Werror=maybe-uninitialized]
I'm rejecting this one because it doesn't compile, but I'd be happy to accept
an updated patch with these issues fixed. Just upload it to this bug and mark
the old patch as 'obsolete' when you do.
Evan
You are receiving this mail because:
- You are watching all bug changes.