Comment # 170
on bug 8416
from Pascal Quantin
(In reply to comment #169)
> (In reply to comment #168)
> > (In reply to comment #167)
> > > Created attachment 10385 [details]
> > > [PATCH 2] Bluetooth: Cleanup last part of Bluetooth dissectors
> >
> > Was the removal of the memset in this hunk done on purpose?
> > @@ -1995,7 +1998,7 @@ btl2cap_sdp_tap_packet(void *arg _U_, packet_info
> > *pinfo _U_, epan_dissect_t *ed
> > psm_service->adapter_id == adapter_id &&
> > psm_service->chandle == chandle &&
> > psm_service->psm == psm)) {
> > - psm_service = se_new0(psm_service_t);
> > + psm_service = wmem_new(wmem_file_scope(), psm_service_t);
> > psm_service->interface_id = interface_id;
> > psm_service->adapter_id = adapter_id;
> > psm_service->chandle = chandle;
>
> It wasn't my patch, but it's definitely OK to remove memset because the
> subsequent lines initialize all members of psm_service, so omitting memset
> in the allocation just saves a little time.
Thanks for the check, I was too lazy to check the structure content by myself
;)
You are receiving this mail because:
- You are watching all bug changes.