Wireshark-bugs: [Wireshark-bugs] [Bug 8467] Need functions to mirror val_to_str

Date: Tue, 19 Mar 2013 09:30:53 +0000

Comment # 3 on bug 8467 from
Actually I couldn't figure out so far a concrete use-case where
case-insensitive version should be needed.
If we are think about all the permutation we can make with a string of lenght n
> 1, then a case-insensitive version should be definitely needed, as we can't
think to put inside the array values all the possible permutations...
but if we think about some "well-pre-defined" protocol values...maybe case
sensitive function can be used adding the matching values to the list, with
different case if some ambiguity could be possible.
That's my (newbie) 2 cents
Cheers.
Seba

(In reply to comment #2)
> (In reply to comment #1)
> > Would it be case-sensitive, or case-insensitive?  Might want both functions.
> > For example for the SIP dissector (packet-sip.c), some of its string-to-val
> > lookups are case-sensitive, some not, because of how they're defined in the
> > RFCs.
> 
> The current string_string functions and Sebastiano's original patch are both
> case-sensitive. Adding case-insensitive versions might be useful.
> 
> The sip dissector appears to do its own thing with hash tables at a few
> spots, so I'm not sure how applicable this would be.


You are receiving this mail because:
  • You are watching all bug changes.