Comment # 16
on bug 8446
from Alexis La Goutte
(In reply to comment #14)
> Created attachment 10260 [details]
> AirPcap using UAT preference over obsolete strings
>
> This patch allows Decryption Key Management dialog to work. Marked for
> review because:
>
> 1. I'm not sure if Decryption Key Management dialog really sorts its list by
> "mode" (don't have AirPcap hardware to test), so the IEEE802.11 preferences
> may end up with more keys than it wants. Is that Okay?
> 2. Should airpcap_loader really be reaching into a dissector header file
> (for UAT record type)? I can't say I see any other way to do this...
> 3. "Prefixes" for keys should now be obsolete. Kept the "key stripping"
> code in for backwards compatibility.
> 4. get_key_string() is no longer used. Should it be removed? (removal not
> included in this patch)
Thanks,
I'll try !
You are receiving this mail because:
- You are watching all bug changes.