Comment # 4
on bug 8456
from Evan Huus
(In reply to comment #3)
> (In reply to comment #2)
> > Jakub, CCing you since I suspect the latter is a side-effect of when you
> > reduced the scope of ep_ memory?
>
> Nah, we never supported ep_ memory in col_set_str() [see r30012 and bug
> #3984].
>
> export WIRESHARK_EP_VERIFY_POINTERS=
> $ ./tshark -r /tmp/fuzz-2013-03-10-3098.pcap > /dev/null
>
> ** (process:25207): WARNING **: Dissector bug, protocol RPKI-Router
> Protocol, in packet 16588: column-utils.c:531: failed assertion
> "!ep_verify_pointer(str)"
>
> ** (process:25207): WARNING **: Dissector bug, protocol RPKI-Router
> Protocol, in packet 21520: column-utils.c:531: failed assertion
> "!ep_verify_pointer(str)"
>
> ** (process:25207): WARNING **: Dissector bug, protocol RPKI-Router
> Protocol, in packet 25408: column-utils.c:531: failed assertion
> "!ep_verify_pointer(str)"
>
> ** (process:25207): WARNING **: Dissector bug, protocol RPKI-Router
> Protocol, in packet 34706: column-utils.c:531: failed assertion
> "!ep_verify_pointer(str)"
>
>
> col_set_str(pinfo->cinfo, COL_INFO,
> val_to_str(pdu_type, rtr_pdu_type_vals, "Unknown %d"));
> ^^^^^^^^^^
> unsafe, when value not in value_string array it will return ep_ memory.
I believe this could be fixed by having val_to_str use pinfo-scoped wmem
memory? It would fix tshark at least, not sure if Wireshark requires an even
larger scope?
You are receiving this mail because:
- You are watching all bug changes.