Evan Huus
changed
bug 8431
| What |
Removed |
Added |
| Status |
IN_PROGRESS
|
INCOMPLETE
|
Comment # 15
on bug 8431
from Evan Huus
All of what Steve said is valid. In addition:
- Unless you're exposing functions for other dissectors to use, you don't need
a header file at all. It should all go in the top of the c file. I know this
isn't considered a good practice in some places, but given Wireshark's layout
and the number of dissectors it really helps.
- Please put some line breaks into your hf[] array entries. In general try to
keep columns under 80 characters for readability (though that isn't a hard
rule), but in the hf case it really helps to put each entry on two or three
lines.
- You include two perl scripts to autogenerate certain tables. This is fine,
but please have them include big /* START AUTOGENERATED CODE - DO NOT EDIT */
and /* END AUTOGENERATED CODE */ comments so that future maintainers don't
accidentally let the tables get out of sync with the generators. Including a
comment indicating which script was used to generate the code would also be
nice.
You are receiving this mail because:
- You are watching all bug changes.