Evan Huus
changed
bug 8414
| What |
Removed |
Added |
| Attachment #10202 Flags |
review_for_checkin?
|
review_for_checkin+
|
Comment # 17
on bug 8414
from Evan Huus
Comment on attachment 10202 [details]
Revised implementation
Thanks for the updated patch, I've committed it in r49190.
I still have a few minor questions, but nothing major:
- CppCheck points out the following: packet-usb-video.c:2075: style: Duplicate
conditions in 'if' and related 'else if'. The latter is a TODO, but presumably
the else-if should be checking something different?
- In dissect_usb_vid_control the subdissector work would perhaps be
better-handled by a regular subdissector table, called with dissector_try_uint?
It seems to be doing approximately the same thing, but there are perhaps minor
differences that make this not suitable? The relevant functions are in
epan/packet.h.
In general though, really excellent work.
Cheers,
Evan
You are receiving this mail because:
- You are watching all bug changes.