Wireshark-bugs: [Wireshark-bugs] [Bug 8416] remove C++ incompatibilities

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 07 Mar 2013 22:00:49 +0000

changed bug 8416

What Removed Added
Attachment #10211 Flags   review_for_checkin?

Comment # 44 on bug 8416 from 
Created attachment 10211 [details]
patch to remove C++ incompatibilities from UAT_VS_DEF macro and all uses

The UAT_VS_DEF macro defines two functions which are used to set the value of a
field based on a string (xx_set_cb) and get a string based on the value
(xx_tostr_cb).  Unfortunately the original version of the set_cb function
relied on an implicit cast from a guint32 to whatever the field value might be,
including an enum type.  This is fine in C, but forbidden in C++, so this
change was implemented to eliminate this problem by adding a "default_t"
(default type) argument just after the "rec_t" (record type) argument already
passed and by making the corresponding change to each place in the code that
this macro is called.

You are receiving this mail because:
  • You are watching all bug changes.