Wireshark-bugs: [Wireshark-bugs] [Bug 8414] Add USBVIDEO (UVC) dissector

Date: Wed, 06 Mar 2013 13:44:00 +0000

Comment # 15 on bug 8414 from
(In reply to comment #14)
> I think I have addressed all of your comments (thanks!) except for the last.
> Can you give me a hint as to what you had in mind? It's not obvious to me
> how to get a 35-year-old preprocessor to help here.

I thought I had a clever and simple way of doing this when I wrote the comment,
but now I can't remember what it was. A quick google shows that it is possible,
but ugly, so basically never mind :)

Generating it dynamically at run-time would actually be simpler, since it's
just a for loop at that point, but I don't know if you want the run-time
overhead there (I wonder if there are any compilers smart enough to optimize
that out into it's current static form...?)

Anyways, attach the updated patch and I'll put it on my queue to review and
check in.

Thanks,
Evan


You are receiving this mail because:
  • You are watching all bug changes.