Comment # 9
on bug 8339
from Steve Magnani
> - Removed the 0-length case from proto_item_add_bitmask_tree.
This should be fine. In the UVC dissector I make sure never to call
proto_tree_add_bitmask_len() if len is zero.
> Regarding get_uint_value and get_int_value...
Your understanding is correct. I would submit a patch to fix these but it
occurred to me as I started to create it that the get_int_value() case is more
problematic because of sign extension...which is not addressed by the current
code either. I think I will leave this for someone with more time to address
(and test) it properly and enter it as a bug.
> bug #7933 is no longer relevant and can be closed?
I still think there is a place for FT_BYTES with endianness. In the UVC
dissector there are two places where, because the current implementation has no
such concept, I had to use proto_tree_add_text() instead. I suppose I could
work the patch for 7933 into the UVC code without the need for a consensus on
changing FT_BYTES, but that doesn't seem right to me.
You are receiving this mail because:
- You are watching all bug changes.