Comment # 7
on bug 8424
from Evan Huus
Hi Jiri, thanks for the updated patch. It's looking much better, but it still
has a few very minor issues:
- My version of GCC complains in one spot:
packet-rtp.c: In function 'dissect_rtp_hdr_ext_ed137':
packet-rtp.c:1862:15: error: variable 'ft_len' set but not used
[-Werror=unused-but-set-variable]
- You should probably use tvb_reported_length instead of tvb_length, in order
to correctly handle captures that were truncated.
- The brace positioning around your col_append_fstr() calls is a bit odd. Is
there a reason for that?
Thanks,
Evan
You are receiving this mail because:
- You are watching all bug changes.