Comment # 6
on bug 8424
from Jiri Novak
Dear Evan, Jaap,
I modified patch to address your advices:
> - You use proto_tree_add_uint in a lot of places where proto_tree_add_item
> would probably be preferred
I are right. I modified it to use proto_tree_add_item
> * No need to include stdio.h
Removed
> * Clean up the code indentation. The mode lines state: tabs, width 8.
I'm using different editor setup and I missed it. Sorry for it.
> * No // comment lines
Removed or changed to /* ... */
> * Why changing the order todissect_rtp_hext_rfc5215_onebyte and
> dissect_rtp_hext_rfc5215_twobytes first and then trying
> rtp_hdr_ext_dissector_table ?
RFC5215 is recognised by range of values and I prefer to check it first before
ext_dissector_table.
I have no RFC5215 sample to test it then.
> * Resolve your TODO items
Removed or finished.
> * RTP header extension dissector table should not change from BASE_HEX to
> BASE_NONE.
Reverted.
I attached ED-137 and ED-137A/B samples.
You are receiving this mail because:
- You are watching all bug changes.