[bugzilla-daemon@xxxxxxxxxxxxx]

Pascal Quantin changed bug 8354

What	Removed	Added
CC		pascal.quantin@gmail.com

Comment # 14 on bug 8354 from Pascal Quantin

Hi,

a few comments (wrote before I was Alexis' reply):

- adding 2 entries with the same value in tag_num_vals is a bad idea
(TAG_BSS_ACCESS_DELAY and TAG_WAPI_PARAM_SET). They should probably be combined
IF the EID conflict is confirmed during standardization process. Or use the
heuristic used to identify the right IE to update the Tag text displayed in
Wireshark.

- in the following hunk:
+  /*MIN: 2 + (2+4)+ (2+4) + 4 + 2 + 2 =20*/
+  if (tag_len < 14 /*HEX*/) {
I guess you mean 0x14 or 20 right? Moreover the comment suggests that the sum
should be 22 and not 20.

- in the following hunk:
+      for (loop_cnt=0; loop_cnt < akm_cnt;loop_cnt++) {
You have a potential infinite loop as loop_cnt is defined as guint8 and akm_cnt
is defined as guint16.

- the following hunk is wrong:
+            akm_suite_type = tvb_get_letohs(tvb, offset);
+          proto_tree_add_item(subtree,
hf_ieee80211_tag_wapi_param_set_akm_suite_type,
+                        tvb, offset, 1, ENC_LITTLE_ENDIAN);
+          offset += 1;
You should use a tvb_get_guint8 instead.

- same issue for this hunk:
+            ucast_cipher_type = tvb_get_letohs(tvb, offset);
+          proto_tree_add_item(subtree, 
+            hf_ieee80211_tag_wapi_param_set_ucast_cipher_suite_type,
+                        tvb, offset, 1, ENC_LITTLE_ENDIAN);
+          offset += 1;

- and for this one:
+  mcast_cipher_type = tvb_get_letohs(tvb, offset);
+  proto_tree_add_item(tree,
hf_ieee80211_tag_wapi_param_set_mcast_cipher_suite_type,
+                        tvb, offset, 1, ENC_LITTLE_ENDIAN);
+  offset += 1;

- another infinite loop:
+          for (loop_cnt = 0; loop_cnt < bkid_cnt; loop_cnt++) {
that will be solved by definind loop_cnt as guint16 like for the first comment.

- In the following hunk, you should replace ENC_LITTLE_ENDIAN by ENC_NA:
+              proto_tree_add_item(tree,
hf_ieee80211_tag_wapi_param_set_bkid_list,
+                              tvb, offset, 16, ENC_LITTLE_ENDIAN);

---

      You are receiving this mail because:

• You are watching all bug changes.