Evan Huus
changed
bug 7933
Comment # 3
on bug 7933
from Evan Huus
(In reply to comment #2)
> (In reply to comment #0)
> > Currently, the encoding argument of proto_tree_add_item() is ignored for
> > FT_BYTES fields. Such fields are always displayed big-endian.
>
> An FT_BYTES field is a byte array, not a multi-byte number, so it doesn't
> really have an endianness - the bytes are displayed in the order in which
> they appear in the array.
I would tend to agree with this, but I can also see the obvious use case for a
protocol which defines an arbitrary byte array for which it makes more sense to
display it 'backwards'.
Somehow an arbitrary-length FT_UINT type doesn't seem quite conceptually
equivalent, and we could run into trouble if we're asked to display one of
enormous length in decimal instead of hex.
I'm voting in favour of the patch, though not sufficiently strongly to commit
it without further discussion.
You are receiving this mail because:
- You are watching all bug changes.