[bugzilla-daemon@xxxxxxxxxxxxx]

beroset@mindspring.com changed bug 8416

What	Removed	Added
Attachment #10153 Flags		review_for_checkin?

Comment # 11 on bug 8416 from beroset@mindspring.com

Created attachment 10153 [details]
patch to remove C++ incompatibilities from proto.c

Almost all of this patch was replacing implicit casts with explicit ones, but
two areas should probably get extra scrutiny.   In
proto_registrat_dump_ftypes() (around line 6781 in the proto.c file) the code
iterates through all enum values as though they were int values.  I changed the
code to declare the local value as int to allow incrementing, but then had to
add some casts in the printf statement that comprises the loop.  

The other thing that should be examined by others is the change to the lines
around 5397.  It fills a label with an IPv6 address but does so in a somewhat
strange way in that an array of guint8 (bytes) is used instead of an e_in6_addr
structure (as is used in the proto_custom_set() function in the same file).  I
didn't change it because that would change the number of allocated bytes in the
function but it's a little odd.

---

      You are receiving this mail because:

• You are watching all bug changes.