Michael Mann
changed
bug 8382
What |
Removed |
Added |
Attachment #10149 Flags |
|
review_for_checkin?
|
Comment # 18
on bug 8382
from Michael Mann
Created attachment 10149 [details]
Remove format_text
Why is the format_text even necessary? Can we just provide the string returned
from tvb_get_ephemeral_unicode_string() directly? We already know the value is
going to be bogus/garbage because length > packet length. expert_info may be
overkill.
I think a "better" solution would be to support "unicode" through
proto_tree_add_item so some of these extra steps aren't necessary, but you'd
still have this issue with server_version.
You are receiving this mail because:
- You are watching all bug changes.