[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8387

What	Removed	Added
Status	UNCONFIRMED	INCOMPLETE
CC		alexis.lagoutte@gmail.com
Ever confirmed		1

Comment # 3 on bug 8387 from Alexis La Goutte

Hi Fabio,

It is possible to attach a pcap sample ? (not the output of tshark)

The code don't compile under linux :
acket-zbee-zcl.c:81:13: error: static declaration of
'func_decode_timeinseconds' follows non-static declaration
packet-zbee-zcl.h:187:6: note: previous declaration of
'func_decode_timeinseconds' was here
packet-zbee-zcl.c: In function 'dissect_zcl_config_report':
packet-zbee-zcl.c:1163:12: error: variable 'attr_id' set but not used
[-Werror=unused-but-set-variable]
packet-zbee-zcl.c: In function 'dissect_zcl_attr_data_general':
packet-zbee-zcl.c:1481:14: error: unused variable 'status'
[-Werror=unused-variable]
cc1: all warnings being treated as errors

Also check the indent (you add some tab but files use spaces for indent)

Why add zbee_zcl_boolean_names, it is never used

+        case ZBEE_ZCL_ON_OFF_ATTR_ID_ONOFF:
+            value8 = tvb_get_guint8(tvb, *offset);
+            proto_tree_add_uint(tree, hf_zbee_zcl_on_off_attr_onoff, tvb,
*offset, sizeof(guint8), value8);
+            *offset += (int)sizeof(guint8);

why not use directly proto_tree_add_item ?

It is not possible to add on-off in other zbee dissector file ?

---

      You are receiving this mail because:

• You are watching all bug changes.