Wireshark-bugs: [Wireshark-bugs] [Bug 8368] Minor corrections to the VHT IE decode

Date: Thu, 21 Feb 2013 14:53:50 +0000

Comment # 7 on bug 8368 from
(In reply to comment #3)
> About
> +  {0x00, "8,191 Octets"},
> +  {0x01, "16,383 Octets"},
> +  {0x02, "32,767 Octets"},
> +  {0x03, "65,535 Octets"},
> +  {0x04, "131,071 Octets"},
> +  {0x05, "262,143 Octets"},
> +  {0x06, "524,287 Octets"},
>    {0x07, "1,048,575"},
> 
> Why do not remove the comma ? (Also missing Octets for 0x07 ?)

I thought the commas made the numbers far easier to read, on the other hand you
are the second one who didn't like them so maybe I should just remove them!

I've fixed the "Octets" missing on the last line.

> It will better to add the unit in description of hf ? (
> hf_ieee80211_vht_max_ampdu )

Maybe, though I doubt most people will ever see the description - Where does it
appear? I have never noticed it in the GUI!?

If we do remove the Octets, we should do the same for the other fields with
"Octets" in.


You are receiving this mail because:
  • You are watching all bug changes.