Michael Mann
changed
bug 7490
| What |
Removed |
Added |
| Attachment #8787 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 7490
from Michael Mann
Comment on attachment 8787 [details]
patch
1. Doesn't cleanly merge with current trunk
2. Dissectors should NEVER set the visited flag
3. get_sdh_level() function parameters have changed and should only be called
once in the function.
4. Reassembly shouldn't be tree dependent.
5. Couldn't packet 1 involve reassembly? Current patch doesn't allow it.
I'm still having a hard time wrapping my head around the "column vs row"
dissection being done. Should smaller chunks of individual "columns" really be
the parts being saved/reassembled and should the dissector be more discriminant
about that and strip out the necessary headers BEFORE inserting it into the
tree?
You are receiving this mail because:
- You are watching all bug changes.