Michael Mann
changed
bug 8326
| What |
Removed |
Added |
| Attachment #9990 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 4
on bug 8326
from Michael Mann
Comment on attachment 9990 [details]
Initial version
Quick review:
1. Port 22222 is not an officially assigned IANA port. You'll need to use
dynamic port registration. See packet-icep.c (or many other dissectors) for an
example.
2. Protocol column should be set even without a tree.
3. Use tvb_get_ephemeral_string() instead of tvb_get_string() to save you the
hassle of freeing the string memory. Also protects against exceptions being
thrown midway through a packet's dissection (which will leak memory in your
current case)
4. Use tvb_reported_length instead of tvb_length
You are receiving this mail because:
- You are watching all bug changes.