Bill Meier
changed
bug 8315
| What |
Removed |
Added |
| Status |
INCOMPLETE
|
CONFIRMED
|
Comment # 8
on bug 8315
from Bill Meier
(In reply to comment #4)
> The patch was not generated by diffing with trunk. I took some nice ideas
> and put it together to make 1.8 branch usable with gtk3.
>
Ok: Looking a little deeper, it appears that the ws_gtk_grid...() stuff in the
patch for gui_utils.[hc] came from trunk & you wanted to use that as part of
your updates to 1.8 which is OK as a suggested patch.
Also: looking a few samples from the patch it seems that the fixes we (I)
recently made to trunk for things like the use of gtk_box_pack_start() instead
of gtk_container_add() are similar to yours but not always the same. In some
cases you chose different values for GTK_EXPAND, etc. and in other cases did
things a bit differently and so on....
So: bottom line:
If you'd care to, we'd love to have your input as to improvements which can be
made for the GTK3 related stuff in trunk. (The choices/changes I made in the
recent work I did certainly may or may not be the best/right choices; We (I)
welcome suggestions and patches to the current trunk).
Bill
(In reply to comment #7)
> Ok, thank you for your replies and opinions. There are some changes, which
> are not present even in trunk branch. Maybe those changes can be moved there
> and 1.8 should work with gtk2 for now.
See above (written before I saw your last comment).
You are receiving this mail because:
- You are watching all bug changes.