Wireshark-bugs: [Wireshark-bugs] [Bug 2992] SDP must reject an offered stream if port is set to

Date: Mon, 11 Feb 2013 15:51:20 +0000

Comment # 13 on bug 2992 from
(In reply to comment #12)
> (In reply to comment #11)
> 
> You may need to provide more context.   Yes in line 1736
> transport_info->media_count is set to -1, however it can't get to line 1906
> with a negative value because it will fail at the for loop in line 1827,
> which requires n to be positive.

Well, there's a lot of context that Coverity provides, but in a nutshell, the
scope of the for loop beginning at line 1827 ends at line 1903, so I do believe
it's possible to reach 1906 with transport_info->media_count set to -1. 
Although Coverity (like just about every other tool) does generate some false
positives, I don't believe that's the case here.  But it's certainly possible
that both Coverity and I could be wrong.

BTW, if you're interested, I believe Gerald could get you a Wireshark Coverity
login.  Initially, anybody could request a login directly from Coverity, but I
*think* that's changed now.


You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.