Wireshark-bugs: [Wireshark-bugs] [Bug 8286] New: (Untriggerable) memory leak in packet-wsp.c

Date: Fri, 01 Feb 2013 03:26:11 +0000
Bug ID 8286
Summary (Untriggerable) memory leak in packet-wsp.c
Classification Unclassified
Product Wireshark
Version 1.8.5
Hardware x86
OS All
Status UNCONFIRMED
Severity Trivial
Priority Low
Component Wireshark
Assignee [email protected]
Reporter [email protected]

Build Information:
Version 1.8.5 (SVN Rev Unknown from unknown)

Copyright 1998-2013 Gerald Combs <[email protected]> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.13, with Cairo 1.12.2, with Pango 1.30.1, with
GLib 2.34.1, with libpcap, with libz 1.2.7, without POSIX capabilities, without
SMI, without c-ares, without ADNS, without Lua, without Python, without GnuTLS,
without Gcrypt, without Kerberos, without GeoIP, without PortAudio, with
AirPcap.

Running on Linux 3.5.0-22-generic, with locale en_US.UTF-8, with libpcap
version
1.3.0, with libz 1.2.7, without AirPcap.

Built using gcc 4.7.2.
--
File: packet-wap.c

Summary: A function allocates memory with g_malloc, but never calls g_free,
therefore leaking memory. However, it is not currently possible to trigger the
function to reach the call to g_malloc.


Code:

In packet-wap.c:

static void
add_post_variable (proto_tree *tree, tvbuff_t *tvb, guint variableStart, guint
variableEnd, guint valueStart, guint valueEnd)
{
    ...
    if (valueEnd < valueStart)
    {
        valueBuffer = g_malloc (1);
        valueBuffer[0] = 0;
        valueEnd = valueStart;
    }
    ...
}


However, add_post_variable is only called in two places, and in those two
places, the value passed into valueStart is always >= the value passed into
valueEnd. This bug is being reported in the off-chance that the calling code is
modified, or that another piece of code is modified to call add_post_variable.


You are receiving this mail because:
  • You are watching all bug changes.