Wireshark-bugs: [Wireshark-bugs] [Bug 8258] [PATCH] HomePlugAV dissector: improve device ID deco

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 25 Jan 2013 13:43:53 +0000

Comment # 3 on bug 8258 from 
(In reply to comment #1)
> Hi Florian,
> 
> as this is the second time we need to increase HOMEPLUG_AV_DEV_ID_MASK, why
> not put directly 0xFF? It looks like this byte is not used for anything else
> and keeping a mask might lead to a wrong identification of the device id in
> the future (like QCA6410/QCA6411 being identified as INT6000 without your
> patch)?

Hello Pascal,

This makes sense to me, there is not particular reason why the mask was not
extended to cover the entire byte, v2 attached fixes that. Thanks!

You are receiving this mail because:
  • You are watching all bug changes.