[bugzilla-daemon@xxxxxxxxxxxxx]

Michael Mann changed bug 8239

What	Removed	Added
CC		mmann78@netscape.net

Comment # 16 on bug 8239 from Michael Mann

Two comments:

1. I think bug 4997 should be "deprecated" more than "duplicated" (not sure how
to mark it as such).  This dissector implements a much newer version of the
protocol and I don't see us going back to the version implemented in bug 4997.

2. Should this dissector really register for TCP port 443 (same question posed
in bug 4997)?  
a) http_dissector_add takes care of the TCP port registration
(dissector_add_uint("tcp.port"...), so it's really not necessary to have in the
SSTP dissector itself.
b) Rather than map to a specific port (that isn't IANA registered), I think
this dissector should be completely heuristic (registered only through
heur_dissector_add).  If the first 4 bytes aren't "SSTP", just return "FALSE"
and let another dissector have a crack at it.

---

      You are receiving this mail because:

• You are watching all bug changes.