Michael Mann
changed
bug 8089
Comment # 28
on bug 8089
from Michael Mann
Some minor issues:
1. I don't see much point to the #defines that just map to value_string values.
Will they eventually be used in the code (via switch statements)? All but the
function codes should just have the numeric value right in the value_string.
2. Patch should include not just the dissector file but the small modifications
to /epan/MakeLists.txt and /epan/dissectors/Makefile.common to include it
within the build.
You are receiving this mail because:
- You are watching all bug changes.