[bugzilla-daemon@xxxxxxxxxxxxx]

Pascal Quantin changed bug 8105

What	Removed	Added
Status	UNCONFIRMED	CONFIRMED
CC		pascal.quantin@gmail.com
Ever confirmed		1

Comment # 3 on bug 8105 from Pascal Quantin

Wireshark fails to represent the time on Windows builds only (no issue with
Linux for example) because of this code:

#ifdef _MSC_VER
        /* calling localtime() on MSVC 2005 with huge values causes it to crash
*/
        /* XXX - find the exact value that still does work */
        /* XXX - using _USE_32BIT_TIME_T might be another way to circumvent
this problem */
        if(abs_time->secs > 2000000000) {
            tmp = NULL;
        } else
#endif

Added by Ulf in revision 21759.

According to my test with MSVC2008 and MSVC2010 both with WIN32 and WIN64
builds, such value does not crash anymore.
So I would be tempted to replace the condition by
#if (defined _WIN32) && (_MSC_VER < 1500)
Which would fix the bug reported as 1.8 and trunk branches are generated with
MSVC2010.

Thoughts?

---

      You are receiving this mail because:

• You are watching all bug changes.