[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8089

What	Removed	Added
Status	UNCONFIRMED	INCOMPLETE
CC		alexis.lagoutte@gmail.com
Ever confirmed		1

Comment # 8 on bug 8089 from Alexis La Goutte

Hi
I confirm that Evan said (about proto_tree_add_*..)
There is also some warning with checkhf and checkAPIs tools

And other problem is the dissector not build with gcc (Linux)
packet-selfm.c:430:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c:432:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c:461:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c:463:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c:764:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c: In function 'fmconfig_frame_fast':
packet-selfm.c:876:34: warning: variable 'num_sf' set but not used
[-Wunused-but-set-variable]
packet-selfm.c:876:26: warning: variable 'sf_loc' set but not used
[-Wunused-but-set-variable]
packet-selfm.c:876:21: warning: variable 'len' set but not used
[-Wunused-but-set-variable]
packet-selfm.c: In function 'dissect_relaydef_frame':
packet-selfm.c:934:70: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-selfm.c: In function 'dissect_fmconfig_frame':
packet-selfm.c:1002:70: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-selfm.c: In function 'dissect_fmdata_frame':
packet-selfm.c:1087:109: warning: variable 'dig_word' set but not used
[-Wunused-but-set-variable]
packet-selfm.c: In function 'dissect_foconfig_frame':
packet-selfm.c:1289:70: error: unused parameter 'pinfo'
[-Werror=unused-parameter]
packet-selfm.c: In function 'dissect_fastser_frame':
packet-selfm.c:1428:76: warning: variable 'fastser_elementlist_tree' set but
not used [-Wunused-but-set-variable]
packet-selfm.c: In function 'dissect_selfm_tcp':
packet-selfm.c:2139:20: error: passing argument 7 of 'tcp_dissect_pdus' from
incompatible pointer type [-Werror]
packet-tcp.h:105:1: note: expected 'dissector_t' but argument is of type 'int
(*)(struct tvbuff_t *, struct packet_info *, struct proto_tree *)'
packet-selfm.c: At top level:
packet-selfm.c:725:25: error: 'selfm_fastser_func_code_vals_ext' defined but
not used [-Werror=unused-variable]

---

      You are receiving this mail because:

• You are watching all bug changes.