[bugzilla-daemon@xxxxxxxxxxxxx]

Michael Mann changed bug 5881

What	Removed	Added
Attachment #9676 Flags	review_for_checkin?	review_for_checkin-

Comment # 28 on bug 5881 from Michael Mann

Comment on attachment 9676 [details]
MIH protocol (802.21b) patch

Quick review:

1. patch should be against latest SVN instead of v1.8.3
2. reorder functions so that the function declarations aren't needed at the top
of the file.
3. Remove HAVE_CONFIG_H
4. Use consistent white space rules (either all spaces or all tabs, don't mix).
 Looks like all spaces is more predominantly used.
5. Building on Windows I get the following compiler errors/warnings
packet-mih.c(1099) : error C2220: warning treated as error - no 'object' file
generated
packet-mih.c(1099) : warning C4244: '=' : conversion from 'guint64' to
'guint8', possible loss of data
packet-mih.c(1134) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(1156) : warning C4244: '+=' : conversion from 'guint64' to
'gint16', possible loss of data
packet-mih.c(1157) : warning C4244: '-=' : conversion from 'guint64' to
'gint16', possible loss of data
packet-mih.c(1333) : warning C4145: '==' : relational _expression_ as switch
_expression_; possible confusion with '='
packet-mih.c(1345) : warning C4145: '==' : relational _expression_ as switch
_expression_; possible confusion with '='
packet-mih.c(1356) : warning C4145: '==' : relational _expression_ as switch
_expression_; possible confusion with '='
packet-mih.c(1367) : warning C4145: '==' : relational _expression_ as switch
_expression_; possible confusion with '='
packet-mih.c(1837) : warning C4047: 'initializing' : 'char' differs in levels
of indirection from 'void *'
packet-mih.c(2095) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2122) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2175) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2175) : warning C4244: 'function' : conversion from 'guint64' to
'const gint', possible loss of data
packet-mih.c(2183) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2183) : warning C4244: 'function' : conversion from 'guint64' to
'const gint', possible loss of data
packet-mih.c(2187) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2187) : warning C4244: 'function' : conversion from 'guint64' to
'const gint', possible loss of data
packet-mih.c(2191) : warning C4244: 'function' : conversion from 'guint64' to
'gint', possible loss of data
packet-mih.c(2191) : warning C4244: 'function' : conversion from 'guint64' to
'const gint', possible loss of data
packet-mih.c(3847) : warning C4047: 'initializing' : 'const void *' differs in
levels of indirection from 'int'

---

      You are receiving this mail because:

• You are the assignee for the bug.
• You are watching all bug changes.