[email protected]
changed
bug 8082
| What |
Removed |
Added |
| Attachment #9678 is obsolete |
|
1
|
| Attachment #9678 Flags |
review_for_checkin?
|
|
| Attachment #9683 Flags |
|
review_for_checkin?
|
Comment # 3
on bug 8082
from [email protected]
Created attachment 9683 [details]
patch v2
>- there are a few typo errors to fix (like "Disonnect" for example)
Hope that fixed.
>- any reason for not adding a define for each SM PDU type? Because the value is not used in conditional statements?
Yes, in most of undeclared PDU types there is nothing to dissect, some of them
I haven't seen in the wild (only in Yate sources). So I don't see any use of
that defines. Should I add them?
>- personally I would prefer a "switch case" instead of multiple "else if" statements. Maybe just a matter of taste
Done.
>- instead of fetching the same u32 multiple times with tvb_get_ntohl(tvb,offset), you could store the result in a variable and reuse it as you suggested. It would avoid some useless processing
Done.
>- why not use a dedicated hf entry instead of reusing hf_sm_retrieval_type to dump the BSN?
Missed that, fixed.
Will attach traces later today.
You are receiving this mail because:
- You are watching all bug changes.