Michael Mann
changed
bug 7426
| What |
Removed |
Added |
| Status |
CONFIRMED
|
INCOMPLETE
|
Comment # 8
on bug 7426
from Michael Mann
> I can attach code, but don't know is it possible to use sqlite and zzip or not.
sqlite is public domain:
http://www.sqlite.org/copyright.html
zzip is GNU LGPL
http://compressionratings.com/i_zzip.html
I'll let people more versed in licensing comment on its ability to be included
in Wireshark. However, if it is you'll need to include more makefile
modifications in your patch.
As for the patch itself:
1. Wireshark doesn't allow file extensions as a way to distinguish file types.
Both Ubiqua and Ember do need the filename for their external API, but that
doesn't mean filetype verification should include an extension.
2. Ember-ISD
a) Wrap ZZIP functionality in #define for platforms/builds that don't support
it
b) CRC algorithm should already be provided in wsutil
c) Not sure if "2 byte signature" "PK" is strong enough to ensure filetype.
3. TI-SmartRF
a) memory leak if file_seek() fails.
4. Ubiqua
a) Wrap SQLite functionality in #define for platforms/builds that don't support
it
You are receiving this mail because:
- You are watching all bug changes.