Michal Labedzki
changed
bug 5032
| What |
Removed |
Added |
| Attachment #9598 Flags |
|
review_for_checkin?
|
Comment # 23
on bug 5032
from Michal Labedzki
Created attachment 9598 [details]
[PATCH 3.1/6] Bluetooth: Cleanup bthci_acl
(In reply to comment #20)
> There's a shadowed variable in packet-bthci_acl.
>
>
> CC libdissectors_la-packet-bthci_acl.lo
> packet-bthci_acl.c: In function 'dissect_bthci_acl':
>
> packet-bthci_acl.c:161:25: warning: declaration of 'k_frame_number' shadows
> a previous local [-Wshadow]
>
> packet-bthci_acl.c:105:31: warning: shadowed declaration is here [-Wshadow]
>
>
> The variable declared in in line 161 is never set to a value so I suspect
> this declaration should be removed.
>
> Please advise.
>
> (No need to submit a patch. Just let us know what should be done; I (or
> someone else can make the change).
Thanks for pointing that. From now I enable "--enable-extra-gcc-checks" in my
configure. Also I try to fix other warnings and make couple of spaces fixes.
(please see patch within commit message)
You are receiving this mail because:
- You are the assignee for the bug.
- You are watching all bug changes.