Wireshark-bugs: [Wireshark-bugs] [Bug 5622] Incomplete support of OSI protocol dissectors for CL

Date: Sat, 17 Nov 2012 18:09:49 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5622

--- Comment #20 from Guy Harris <guy@xxxxxxxxxxxx> 2012-11-17 18:09:48 PST ---
Some additional changes checked in:

whitespace cleanup (tabs -> spaces);

typo fixes (Transport Protocol Data Unit is "TPDU" rather than "TDPU");

defaulting to disabling the COTP handling of ATN (so that, for example,
dissection of captures with TP0 or TP1 traffic, e.g. RDP-over-TP[01]-over-TCP,
still work by default);

handling the extended checksums by passing to the extended checksum routines
the lengths of, and pointers to the data of, the DSAP and SSAP (rather than
copying them into a global buffer - global buffers aren't the best way to
handle things, and the copy was assuming you always had 24 bytes of destination
and source address lengths and addresses, and not all CLNP traffic does).

Perhaps for the TP0/TP1 stuff it should dissect data packets with a 2-octet
COTP header as TP0/TP1 regardless of the setting of the preference for ATN.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.