Wireshark-bugs: [Wireshark-bugs] [Bug 7914] New: "nmake packaging_papps" fails if the line end i

Date: Fri, 26 Oct 2012 07:34:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7914

           Summary: "nmake packaging_papps" fails if the line end is CRLF
           Product: Wireshark
           Version: 1.9.x (Experimental)
          Platform: x86
        OS/Version: Windows 7
            Status: NEW
          Severity: Trivial
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: samano.and@xxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
If the source codes are checked out using TortoiseSVN on Windows,
"nmake -f Makefile.nmake packaging_papps" fails in the middle.

This is because the line end of packaging\nsis\wireshark.nsi is CRLF in this
case,
and ws-manifest.pl cannot handle such case.

Procedure:
1. Follow step-by-step guide
http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
   Use TortoiseSVN for the SVN client.
   I use Visual C++ 2008 (EE or commercial) for the build.

2. Check out the source code r45796.

3. After the set up, run:
   nmake -f Makefile.nmake setup
   nmake -f Makefile.nmake distclean
   nmake -f Makefile.nmake all
   nmake -f Makefile.nmake packaging
   nmake -f Makefile.nmake packaging_papps

Error output is below. (Sorry in Japanese)

------------------------------
        "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC\BIN\nmake.exe" /
                  -f makefile.nmake wireshark.manifest

Microsoft(R) Program Maintenance Utility Version 9.00.21022.08
Copyright (C) Microsoft Corporation.  All rights reserved.

        perl ws-manifest.pl nsis/wireshark.nsi > wireshark.manifest
defined(@array) is deprecated at ws-manifest.pl line 52.
        (Maybe you should just omit the defined()?)
looking for $INSTDIR
looking for $INSTDIR\${GTK_ENGINES_DIR}
looking for $INSTDIR\${GTK_ETC_DIR}
looking for $INSTDIR\${GTK_MODULES_DIR}
looking for $INSTDIR\${GTK_SCHEMAS_DIR}
looking for $INSTDIR\diameter
looking for $INSTDIR\dtds
looking for $INSTDIR\help
looking for $INSTDIR\radius
looking for $INSTDIR\snmp\mibs
looking for $INSTDIR\tpncp
looking for $INSTDIR\wimaxasncp
looking for $PROFILE
looking for '$INSTDIR\plugins\${VERSION}'
ERROR
The following directories have no known location on a U3 device:
        '$INSTDIR\plugins\${VERSION}'
NMAKE : fatal error U1077: 'perl' : リターン コード '0xff'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
9.0\
VC\BIN\nmake.exe"' : リターン コード '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio
9.0\
VC\BIN\nmake.exe"' : リターン コード '0x2'
Stop.

C:\wireshark>
------------------------------

To solve the issue, we can either:
a) change the line end of packaging\nsis\wireshark.nsi to LF and
   remove the property svn:eol-style=native, or
b) modify ws-manifest.pl.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.