https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7740
Michal Labedzki <michal.labedzki@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9379| |review_for_checkin?
Flags| |
--- Comment #8 from Michal Labedzki <michal.labedzki@xxxxxxxxx> 2012-10-19 01:20:22 PDT ---
Created attachment 9379
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9379
[PATCH] Bluetooth: Fix deadcode areas and improper use of negative value in
AVRCP
(In reply to comment #7)
> If the offset is out of bounds, both tvb_length_remaining() and
> tvb_reported_length_remaining() return -1. The code needs to be able to handle
> this. Detected by Coverity and reported as CID 728016: Improper use of
> negative value.
>
> Also, in dissect_vendor_dependant():at line 1022, company_id is guaranteed to
> be equal to COMPANY_BT_SIG. Further checks at lines 1031 and 1595 are
> therefore unnecessary, and in the latter case, lead to a dead code detection
> since the proto_tree_add_item at line 1600 will never be executed. Detected by
> Coverity and reported as CID 728014: Logically dead code.
Thanks for the prompt. Attached patch should fix it.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.