https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3817
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9258|0 |1
is obsolete| |
Attachment #9258|review_for_checkin? |
Flags| |
Attachment #9259|0 |1
is obsolete| |
Attachment #9259|review_for_checkin? |
Flags| |
Attachment #9280| |review_for_checkin?
Flags| |
--- Comment #7 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-10-05 14:51:02 PDT ---
Created attachment 9280
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9280
Save the size and position of the expert info dialog. Set initialize position
to center on parent.
Before I continue any further, I was hoping to get some feedback on this patch.
It only saves the expert info dialog window size and position for now, but I
did add a change to be able to specify the initial position of the window if
one hadn't been saved previously. I chose the "center on parent" position for
it and for other windows that were already calling
[dlg_]window_new_with_geom(). If all windows end up using "center on parent"
as the initial position, then we could eliminate the parameter and just always
set it that way inside window_new_with_geom(), but I thought it would likely be
the case that we'd end up having some exceptions to this.
Of note, "center on parent" doesn't actually work with Windows, at least not in
my testing. So on Windows, that gets translated to simply, "center". I don't
know if it will work on other OS's or not, so maybe someone could test it and
confirm if it does or doesn't.
Some implications to consider are,
(1) As we add the ability to save more and more window sizes and positions, the
recent_common file is going to continue to grow. I don't know if that will be
a problem? I suspect not, but figured I'd mention it.
(2) We may not need/want to save *all* dialog size and positions. But if not,
then I think it would still be useful to at least change the default position
from "unspecified" to either "center on parent" or simply "center". I think
this would be helpful particularly when working with multiple monitors,
especially if Wireshark's main window is not located on the primary monitor.
Anyway, identifying which dialogs are worth saving position & size information
for and which are not will likely be a subjective, iterative process. There
are quite a few of them (I will attach a quick list). Maybe we just start with
"center[ on parent]" and go from there?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.