https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7715
--- Comment #19 from Martin Kaiser <wireshark@xxxxxxxxx> 2012-09-24 06:32:25 PDT ---
(In reply to comment #18)
> (In reply to comment #16)
> > Created attachment 9216 [details]
> > [PATCH] gsm-sim: Fixes required by Bluetooth SAP
> >
> > Changelog:
> > Now patch does not break compatibility with mentioned osmocom mode.
> >
> > Is patch "9133: [PATCH 2/3] iso7816: Add subdissector ISO 7816-3" ok with you?
>
> Hi Michal,
>
> thanks a lot for your proposal. I tried to ping Harald (author of the gsm_sim
> dissector) with no success so far. Let's see if he agrees with your patch in
> the coming days or comes up with something else.
> On my side, I do not have any objection.
Hi Pascal, Michael,
the other pending patch [2/3] is against my code, sorry for the delay. As I
said before, I have no issues with making iso7816_atr a dissector of its own so
that you can use it.
I'm not sure about the data parameter. A boolean called "subdissector" is
probably not a good idea as many different dissectors may use the atr in the
future. There was some discussion on -dev about requiring a specific format for
data, I'm not sure if there's a conclusion.
Anyway, I propose that I'll take the non-contentious part of the patch and
commit it as soon as I have a bit of time (most likely today or tomorrow).
So you have sth to work with although for now, the info column won't look
exactly as you want it.
Best regards,
Martin
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.