Wireshark-bugs: [Wireshark-bugs] [Bug 7403] [PATCH] epan/Makefile.am filters out python-related

Date: Sat, 8 Sep 2012 05:43:36 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7403

--- Comment #15 from pi-rho <ubuntu@xxxxxx> 2012-09-08 05:43:34 PDT ---
Just to be clear, my first patch, now deprecated, corrected a logic error. In
other places within the same Makefile.am and in wsutil/Makefile.am, the same
pattern is used:  
if !HAVE_something
   def_sym_filter_symbols += /symbol to filter/ {next;};
endif

(In epan/Makefile.am see "if !HAVE_PLUGINS ...")

With https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9098, it needs the
positive condition to trigger and use awk to append to libwireshark.sym.

if HAVE_LIBY
def_sym_filter_symbols += END {print "extra symbol added to end";};
...
endif

That being said, applying both
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8681 and
https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9098 will be incorrect.

The first two patches failed on Solaris and OSX because some of the symbols
added to libwireshark.def weren't being filtered out. I was about to upload an
updated patch that had an updated filter, but realized that it would never work
on Windows, since the .def is being used directly -- and the .def file is a
native configuration file for Microsoft's LINK.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.