https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7403
--- Comment #13 from Guy Harris <guy@xxxxxxxxxxxx> 2012-09-08 00:20:00 PDT ---
(In reply to comment #12)
> *This* patch was OK, assuming the whole def_sym_filter_symbols stuff is OK;
> there was truly a logic error there.
...and the change from that patch *wasn't* reverted in 44805 (another "#if
HAVE_LIBPY" was changed, which broke the build, so that part of 44805 was
undone) and shouldn't be reverted. (44805 also reverted the change to
libwireshark.def, which was necessary.)
> (If that stuff isn't OK, it's not OK for Lua, either, and needs to be fixed.)
It *appears* to be OK - I applied the old second patch and was able to build
without enabling Python support, so I'm not sure why that broke the build on
UN*Xes; the .def.sym Makefile rule (in the top-level Makefile.am.inc) should
have run sed on libwireshark.def and stripped out those entries.
The *ideal* scheme would be one in which we have a source file used to generate
the .def file with MSVC++ and the .sym file on UN*Xes, with support for
conditional tests in that file, and rules in Makefile.am.inc *and*
Makefile.nmake *and* the CMake files that will remove anything if'ed out with
the conditions.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.