https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6881
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #8943|review_for_checkin? |review_for_checkin-
Flags| |
--- Comment #20 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2012-08-30 08:06:56 PDT ---
Comment on attachment 8943
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8943
sid parsing fix
offset isn't needed in this function.
Where does it say in RFC 6374 that if the T bit is set that DS can be
considered part of the Session Identifier? I don't think this is correct and
would suggest removing that special case. Doing so also means that there's no
need for mpls_pm_build_cinfo() to return "sid" and all occurrences of
"proto_tree_add_uint(pm_tree, hf_mpls_pm_session_id, tvb, offset, 4, sid);"
should be changed to "proto_tree_add_item(pm_tree, hf_mpls_pm_session_id, tvb,
offset, 4, ENC_BIG_ENDIAN);" instead once:
&hf_mpls_pm_session_id,
{
"Session Identifier",
"mpls_pm.session.id",
FT_UINT32, BASE_DEC,
NULL, 0x0,
NULL, HFILL
}
is changed to:
&hf_mpls_pm_session_id,
{
"Session Identifier",
"mpls_pm.session.id",
FT_UINT32, BASE_DEC,
NULL, 0x0xffffffc0,
NULL, HFILL
}
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.