https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7675
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mmann78@xxxxxxxxxxxx
--- Comment #7 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-08-29 17:51:40 PDT ---
(In reply to comment #0)
> Created attachment 9019 [details]
> [PATCH] Bluetooth: Add AVCTP dissector
1. Can you use the fragment reassembly API from reassembly.[ch]?
2. While I've been trying to rid the dissectors of (unnecessary) g_ alloced
memory, unfortunately for fragmentation it makes sense because otherwise you're
stuck with twice the memory necessary (fragmented and then as a reassembled
packet), because se_ alloced memory can't be explicitly freed. If you can't do
#1 (where the g_ alloced memory is "hidden" from the dissector), I would
recommend using g_ alloced memory for your fragmentation algorithm. Even
better if you can modify the reassembly API to allow your dissector to use it.
3. Would it be possible to use p_get_proto_data() instead of setting
pinfo->private_data?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.