Wireshark-bugs: [Wireshark-bugs] [Bug 7664] GMR-1: Various enhancements

Date: Sat, 25 Aug 2012 11:13:37 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7664

Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pascal.quantin@xxxxxxxxx

--- Comment #7 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-08-25 11:13:36 PDT ---
(In reply to comment #1)
> Created attachment 8999 [details]
> GMR1 RACH packets dissection

Hi,
a few comments:

- Is the '!!' here on purpose?
+    *is_moc = !!(ec & 0x10);

- hf_rach_retry_cnt and hf_rach_precorr have overlapping bits. Is it expected
or should hf_rach_precorr and hf_rach_rand_ref be read at another offset?
+    /* Retry counter */
+    proto_tree_add_item(tree, hf_rach_retry_cnt,
+                        tvb, offset + 1, 1, ENC_BIG_ENDIAN);
+
+    /* Precorrection Indication */
+    proto_tree_add_item(tree, hf_rach_precorr,
+                        tvb, offset + 1, 1, ENC_BIG_ENDIAN);

- the use of tvb_get_ptr() is not recommended in the developer's guide and in
tvbuff.h. Any reason for not using the tvb_get_guint8() functions in
_parse_dialed_number()?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.