https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7654
Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pascal.quantin@xxxxxxxxx
--- Comment #3 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2012-08-20 02:36:06 PDT ---
Hi Lorand,
a few comments regarding your patch:
- in line 1302
proto_tree_add_item(lisp_tree, hf_lisp_xtrid, tvb, offset, LISP_XTRID_LEN,
ENC_BIG_ENDIAN);
should be replaced by
proto_tree_add_item(lisp_tree, hf_lisp_xtrid, tvb, offset, LISP_XTRID_LEN,
ENC_BIG_ENDIAN);
as hf_lisp_xtrid is FT_BYTES
- why not use expert_add_info_format instead of proto_tree_add_text for
warnings/errors? It would permit you to benefit from the existing expert system
- the proto_tree_add_text calls you added in the new functions
(dissect_lcaf_natt_rloc, dissect_lcaf_afi_list, dissect_lisp_mapping...) will
make the items (like IP address) unfilterable. Is this desirable? Will you
enhance it in the future?
BTW, I saw that hf_lisp_mrep_flags and hf_lisp_mreg_flags are unused. Were they
supposed to be used so as to create a subtree? Can we remove them or should we
add this subtree?
Regards,
Pascal.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.