Wireshark-bugs: [Wireshark-bugs] [Bug 7046] Enhancement to LDP dissector to support changes prop

Date: Wed, 8 Aug 2012 10:45:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7046

--- Comment #12 from Aditya Ambadkar <arambadk@xxxxxxxx> 2012-08-08 10:45:11 PDT ---
(In reply to comment #11)
Fix is under fuzz test

Something that we noted which is related mostly to fix for
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5013. Code defines only one
parameter bfd in dissect_tlv and four parameters bfd1, bfd2, bfd3 and bfd4 in
dissect_tlv_fec. Interesting enough only the first one (bfd and bfd1) are used
in the function dissect_subtlv_interface_parameters. 

Here LSP Ping, MPLS ping, BFD1..4 are bitmasks representing different CV types. 
http://tools.ietf.org/html/rfc5085#section-4
http://tools.ietf.org/html/rfc5885#section-3

The dissect_subtlv_interface_parameters is missing the handling of BFD 2..4.
For the crash patch, we decided to add the bfd2..4 in dissect_tlc function(in
the diff). We plan to open a separate bug to fix
dissect_subtlv_interface_parameters to make it handle BFD2..4. (Thanks to Arun
Arunachalam for this analysis)

> (In reply to comment #9)
> > Aditya, any update?  This overrun managed to manifest itself as a crash for at
> > least one user.
> 
> Just an update on the situation. I have a proposed fix for the issue, I am
> working with a senior engineer to make sure we do the right thing.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.