Wireshark-bugs: [Wireshark-bugs] [Bug 7547] New: ERF dissector cleanup

Date: Mon, 30 Jul 2012 22:33:07 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7547

           Summary: ERF dissector cleanup
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Medium
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: stephen@xxxxxxxxxx


Stephen Donnelly <stephen@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8859|                            |review_for_checkin?
              Flags|                            |

Created attachment 8859
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8859
ERF dissector display cleanup patch

Build Information:
wireshark 1.9.0 (SVN Rev 44149 from /trunk)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.6, with Cairo 1.10.2, with Pango 1.29.3, with
GLib 2.30.0, with libpcap, with libz 1.2.3.4, with POSIX capabilities (Linux),
with libnl 1, with SMI 0.4.8, with c-ares 1.7.4, without Lua, without Python,
with GnuTLS 2.10.5, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with
PortAudio <= V18, without AirPcap.

Running on Linux 3.0.0-22-generic, with locale en_NZ.UTF-8, with libpcap
version
1.3.0-PRE-GIT_2011_08_23, with libz 1.2.3.4, GnuTLS 2.10.5, Gcrypt 1.5.0.

Built using gcc 4.6.1.

--
Cleanup patch for the ERF dissector, mostly cosmetic.

Flatten unnecessary tree hierarchy
Minimise use of proto_tree_add_text()
Remove PROTO_ITEM_SET_GENERATED()
Eliminate some redundant code
Improve erf.flags display
Capitalise field names
Set reserved fields to BASE_HEX

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.