Wireshark-bugs: [Wireshark-bugs] [Bug 7377] Statusbar on GTK3 too big in capture window

Date: Thu, 19 Jul 2012 02:58:15 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7377

Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #19 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-07-19 02:58:14 PDT ---
(In reply to comment #18)
> Closing as fixed, opened a separate bug for the byte_view problem(s).

Reopening. I think we should review all use of *gtk_container_add* for boxes.

When you use gtk_[vh]box_new() and use gtk_container_add() it'll really call:
  gtk_box_pack_start(GTK_BOX (container), widget, .expand = TRUE, TRUE, 0);

But if you create box with gtk_box_new() it'll really call:
  gtk_box_pack_start(GTK_BOX (container), widget, .expand = FALSE, TRUE, 0);

(from gtk-3.4.4 sources)

Generally to make GUI consistent I'd rather change all gtk_container_add() to
gtk_box_pack_start().

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.